fix: add import fallbacks for missing optional tokens (v1.2.3)#13
Merged
fix: add import fallbacks for missing optional tokens (v1.2.3)#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
import-export.shmore tolerant of incomplete theme files by filling the two commonly omitted optional tokens during import.Context / Motivation
Users can have valid theme files that omit
selectedListItemTextorbackgroundMenu, but the import flow previously treated those gaps as hard failures instead of following the same fallback behavior used by the app.Changes
selectedListItemText->backgroundbackgroundMenu->backgroundElementdefs, and single-mode import handling while producing clearer missing-token errors for truly required fields1.2.3Testing
npm run testnpm run lintnpm run buildpublic/import-export.shwith the provided incomplete theme JSONVersion
Patch release:
1.2.3