fix: governance gaps surfaced by encode implementation bugbot review#98
Merged
Conversation
Four governance bugs produced four code bugs in PR klappy/oddkit#96. The server had no governance to follow for these cases and improvised. Fixes: 1. Removed bare 'found' from observation trigger words — collided with Learning's 'found that' during fallback regex classification 2. Added fallback: true to observation.md frontmatter — observation is the canonical fallback for unmatched paragraphs 3. Added ## Fallback Behavior section to how-to-write-encoding-types.md — specifies how fallback type is resolved via frontmatter 4. Added ## Scoring Algorithm section to how-to-write-encoding-types.md — centrally defines score→level mapping (strong=max, adequate=60%+, weak=40%+, insufficient<40%) 5. Added ## Context vs Input section to how-to-write-encoding-types.md — input generates artifacts, context only informs quality scoring Prompt over code requires complete governance. These gaps caused the server to improvise, and bugbot caught the improvisations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four governance gaps caused four code bugs in klappy/oddkit#96. The server had no governance to follow for these cases and improvised — bugbot caught the improvisations.
Fixes
fallback: trueto observation.md frontmatter — observation is the canonical fallback for unmatched paragraphsPrompt over code requires complete governance. Gaps force the server to improvise.
Note
Medium Risk
Although this is doc-only, these governance changes can alter runtime encode classification and quality scoring wherever the server dynamically follows these articles.
Overview
Adds explicit governance for encode edge-cases by documenting fallback type resolution, score-to-quality level thresholds, and how
contextis used only for quality scoring (not artifact creation).Marks
odd/encoding-types/observation.mdwithfallback: trueand removes the bare trigger wordfoundto reduce misclassification during unstructured fallback parsing.Reviewed by Cursor Bugbot for commit 53ef9c7. Bugbot is set up for automated code reviews on this repo. Configure here.