Skip to content

Promote main → prod: internal knowledge_base_url rename (#110)#111

Merged
klappy merged 1 commit into
prodfrom
main
Apr 19, 2026
Merged

Promote main → prod: internal knowledge_base_url rename (#110)#111
klappy merged 1 commit into
prodfrom
main

Conversation

@klappy
Copy link
Copy Markdown
Owner

@klappy klappy commented Apr 19, 2026

Promote main → prod

Internal-rename cycle complete. Aligns worker code with the user-facing knowledge_base_url contract shipped in #108 / #109 (E0008.3).

Contents

Validation performed

Orchestrator: Claude Opus 4.7 (fresh session).

Cross-model independent validator: Claude Sonnet 4.6 (fresh agent object, fresh session, zero shared context). Verified all 8 acceptance criteria directly against the artifact (grep / typecheck / live smoke / PR-body diff). DISPOSITION: VERIFIED. Zero findings.

  • ✅ Zero target-pattern residues across workers/src/** (canon_url, canonUrl, CanonUrl, ZipBaselineFetcher, BASELINE_URL)
  • npm run typecheck clean on workers/
  • ✅ Branch-preview smoke (CF auto-deploy of rename/internal-knowledge-base-url): 24 / 24 pass
  • ✅ Main-preview smoke (CF auto-deploy of merged main): 24 / 24 pass
  • ✅ Cursor Bugbot automated review on Internal rename: canon* -> knowledge_base* #110: success (medium-risk concern about callers expecting old keys — operator explicitly accepted, zero external users)
  • ✅ All main CI checks green: Workers Builds, Creed Freshness, Test CF Preview, Version Sync

Deliberately out of scope

  • Filename workers/src/zip-baseline-fetcher.ts kept as-is (class renamed only) for diff minimality.
  • baseline_url as a BaselineIndex / API response field — separate semantic concept, not the user-facing URL override.
  • baselineUrl local variable in getIndex() — unrelated to the knowledge_base_url parameter.

No-backward-compat choice

Legacy canon_url argument alias in parseToolCall removed (no dual-accept). Zero external users per E0008.3 handoff — operator decision to just rename and move on.

Refs

  • Handoff: klappy://odd/handoffs/2026-04-19-fresh-session-continuation (P1.1)
  • Pilot ledger: klappy://odd/ledger/2026-04-19-agent-team-pilot
  • Validation canon: klappy://canon/validation-as-epistemic-mode, klappy://canon/principles/verification-requires-fresh-context

Note

Medium Risk
Medium risk because it renames request parameters and env vars and removes the legacy canon_url alias in telemetry parsing, which can break any callers still sending old keys or deployments still configured with BASELINE_URL. Functional behavior should otherwise be unchanged aside from what URL is surfaced in debug/telemetry.

Overview
Aligns the Worker’s internal naming with the public knowledge_base_url contract by renaming canon_* fields and ZipBaselineFetcher to KnowledgeBaseFetcher across MCP tool wiring, orchestrator params/debug envelopes, and the baseline index metadata.

Renames the default repo env var from BASELINE_URL to DEFAULT_KNOWLEDGE_BASE_URL (including wrangler.toml) and updates telemetry to record knowledge_base_url; the previous canon_url argument alias is dropped in parseToolCall.

Reviewed by Cursor Bugbot for commit 6b63cf2. Bugbot is set up for automated code reviews on this repo. Configure here.

Validated by Sonnet 4.6 independent validator (fresh context). Preview smoke: 24/24. Typecheck clean. PR #110.

Ref: klappy://odd/ledger/2026-04-19-agent-team-pilot
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
oddkit 6b63cf2 Commit Preview URL

Branch Preview URL
Apr 19 2026, 02:42 PM

@klappy klappy merged commit fae2df6 into prod Apr 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant