-
Notifications
You must be signed in to change notification settings - Fork 1
feat: nudge unidentified consumers to add ?consumer=yourname #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30fa04c
feat: add consumer identification nudge for unidentified consumers
326a118
fix: add privacy assurance to consumer nudge text
be30f6d
docs: add inline comment explaining no-cache design
0f04b04
Merge branch 'main' into feat/consumer-identification-nudge
klappy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nudge logic duplicated across two tool handler paths
Low Severity
The identical nudge-appending condition and mutation (
consumerSourcecheck +result.assistant_text += ...) is duplicated across the unifiedoddkittool handler and the individual tools loop. If the nudge condition later changes (e.g., adding more source types or excluding error responses whereresult.action === "error"), one location could easily be updated while the other is missed, leading to inconsistent behavior. A small helper likemaybeAppendNudge(result, consumerSource)would centralize this logic.Additional Locations (1)
workers/src/index.ts#L358-L361Reviewed by Cursor Bugbot for commit 0f04b04. Configure here.