inflate: Read more bits when decoding#232
Merged
Conversation
Fixes #231 When a block is not marked as the final block it should be possible to read 10 further bits ahead. The smallest block seems to be a predefined block with a single EOB, which would be 10 bits + EOB from current block (current limit). This should make it possible to fill more bits at the time when decoding.
Owner
Author
|
Maybe @dsnet can spot some obvious flaw. After all he had the great idea to extend it to the size of EOB. If not, this would be a reasonable thing to upstream. |
Owner
Author
|
Tried a few variations on reading. Didn't manage to find anything faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a block is not marked as the final block it should be possible to read 10 further bits ahead without breaking the promise of not overreading.
Fixes #231
Also write blocks with only EOF as TYPE 01 (predefined tables) with only an EOB literal. This saves 3-4 bytes at no cost.
The smallest block seems to be a predefined block with a single EOB, which would be 10 bits + EOB from current block (current limit).
This should make it possible to fill more bits at the time when decoding.