Skip to content

Avx512 optimizations on vector.c #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klmckeig wants to merge 3 commits into
base: binary_quantize_optimize
Choose a base branch
from
Open

Avx512 optimizations on vector.c #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c77d5ab
update
klmckeig Oct 22, 2025
9bb07f9
update
klmckeig Oct 22, 2025
fa45d0f
update
klmckeig Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 19 additions & 101 deletions src/vector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,20 +640,7 @@ vector_negative_inner_product(PG_FUNCTION_ARGS)
VECTOR_TARGET_CLONES static double
VectorCosineSimilarity(int dim, float *ax, float *bx)
{
float similarity = 0.0;
float norma = 0.0;
float normb = 0.0;

/* Auto-vectorized */
for (int i = 0; i < dim; i++)
{
similarity += ax[i] * bx[i];
norma += ax[i] * ax[i];
normb += bx[i] * bx[i];
}

/* Use sqrt(a * b) over sqrt(a) * sqrt(b) */
return (double) similarity / sqrt((double) norma * (double) normb);
return VectorCosineSimilarity(dim, ax, bx);
}

/*
Expand Down Expand Up @@ -760,14 +747,8 @@ Datum
vector_norm(PG_FUNCTION_ARGS)
{
Vector *a = PG_GETARG_VECTOR_P(0);
float *ax = a->x;
double norm = 0.0;

/* Auto-vectorized */
for (int i = 0; i < a->dim; i++)
norm += (double) ax[i] * (double) ax[i];

PG_RETURN_FLOAT8(sqrt(norm));
PG_RETURN_FLOAT8(sqrt((double) VectorL2SquaredDistance(a->dim, a->x, a->x)));
}

/*
Expand All @@ -778,35 +759,12 @@ Datum
l2_normalize(PG_FUNCTION_ARGS)
{
Vector *a = PG_GETARG_VECTOR_P(0);
float *ax = a->x;
double norm = 0;
Vector *result;
float *rx;

result = InitVector(a->dim);
rx = result->x;

/* Auto-vectorized */
for (int i = 0; i < a->dim; i++)
norm += (double) ax[i] * (double) ax[i];

norm = sqrt(norm);

/* Return zero vector for zero norm */
if (norm > 0)
{
for (int i = 0; i < a->dim; i++)
rx[i] = ax[i] / norm;
Vector *result = InitVector(a->dim);

/* Check for overflow */
for (int i = 0; i < a->dim; i++)
{
if (isinf(rx[i]))
float_overflow_error();
}
}
// Use optimized function pointer
VectorL2Normalize(a->dim, a->x, result->x);

PG_RETURN_POINTER(result);
PG_RETURN_POINTER(result);
}

/*
Expand All @@ -826,18 +784,7 @@ vector_add(PG_FUNCTION_ARGS)
CheckDims(a, b);

result = InitVector(a->dim);
rx = result->x;

/* Auto-vectorized */
for (int i = 0, imax = a->dim; i < imax; i++)
rx[i] = ax[i] + bx[i];

/* Check for overflow */
for (int i = 0, imax = a->dim; i < imax; i++)
{
if (isinf(rx[i]))
float_overflow_error();
}
VectorAdd(a->dim, a->x, b->x, result->x);

PG_RETURN_POINTER(result);
}
Expand All @@ -850,29 +797,16 @@ Datum
vector_sub(PG_FUNCTION_ARGS)
{
Vector *a = PG_GETARG_VECTOR_P(0);
Vector *b = PG_GETARG_VECTOR_P(1);
float *ax = a->x;
float *bx = b->x;
Vector *result;
float *rx;
Vector *b = PG_GETARG_VECTOR_P(1);

CheckDims(a, b);
CheckDims(a, b);

result = InitVector(a->dim);
rx = result->x;
Vector *result = InitVector(a->dim);

/* Auto-vectorized */
for (int i = 0, imax = a->dim; i < imax; i++)
rx[i] = ax[i] - bx[i];
// Use optimized function pointer
VectorSubtract(a->dim, a->x, b->x, result->x);

/* Check for overflow */
for (int i = 0, imax = a->dim; i < imax; i++)
{
if (isinf(rx[i]))
float_overflow_error();
}

PG_RETURN_POINTER(result);
PG_RETURN_POINTER(result);
}

/*
Expand All @@ -883,32 +817,16 @@ Datum
vector_mul(PG_FUNCTION_ARGS)
{
Vector *a = PG_GETARG_VECTOR_P(0);
Vector *b = PG_GETARG_VECTOR_P(1);
float *ax = a->x;
float *bx = b->x;
Vector *result;
float *rx;
Vector *b = PG_GETARG_VECTOR_P(1);

CheckDims(a, b);
CheckDims(a, b);

result = InitVector(a->dim);
rx = result->x;
Vector *result = InitVector(a->dim);

/* Auto-vectorized */
for (int i = 0, imax = a->dim; i < imax; i++)
rx[i] = ax[i] * bx[i];

/* Check for overflow and underflow */
for (int i = 0, imax = a->dim; i < imax; i++)
{
if (isinf(rx[i]))
float_overflow_error();
// Use optimized function pointer
VectorMultiply(a->dim, a->x, b->x, result->x);

if (rx[i] == 0 && !(ax[i] == 0 || bx[i] == 0))
float_underflow_error();
}

PG_RETURN_POINTER(result);
PG_RETURN_POINTER(result);
}

/*
Expand Down
Loading