This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feature/nodejob#22
Merged
karthik1729 merged 3 commits intoJun 1, 2023
Merged
Conversation
karthik1729
approved these changes
Jun 1, 2023
nxtcoder17
added a commit
that referenced
this pull request
Jun 29, 2023
* message office refactorings (#18) * [apps/console] msvc templates listing through graphql (#19) * Bugfix/optional oauth in auth api (#20) * [cmd/struct-to-graphql] basic grapqhl schema generation now available, with parsing from go struct as well as any json schema if provided through json-schema tag * [cmd/struct-to-graphql] kind of complete, can successfully generate graphql fields from specified json schema, and inline is also honored * [cmd/struct-to-graphql] adding tests for validating generated schema, now we should be able to refacator it with confidence * WIP: trying to come up with GraphQL schema generation from struct itself * implements provisions for OAuth implementation to be optional for each of the providers * changes container registry for image building and pushing (#21) * Feature/nodejob (#22) * 🚧 wip * 🚧 wip * ✨ new improved nodectrl written nodectrl with support of digital ocean and aws with feature of creation and deletion added. * Feature/nodejob (#23) Node Creation, Cluster Creation, Master node, and worker node management with the cloud provider AWS are done. * 🚧 wip (#24) Left changes form last pull request * [apps/nodectrl] taskfile updated to build nodectrl image locally (#26) * cursor based pagination for console api along with findpaginated for repo * struct-to-graphql types, input types, enums, common-types are being generated, but still need a stable sorting of generated fields, so that diff among multiple generations is kept at small * [cmd/struct-to-graphql] better parsing from struct and json-schema * cmd/struct-to-gql nested structs now have pkgpath prefixed to their name * [cmd/struct-to-graphql] graphql schema generation and dumping with unique nested structs generation, i.e. no repeating of types * [cmd/struct-to-graphql] tests are passing, reaching stability * [cmd/struct-to-graphql] tests are passing, json-schema tests are also passing * [cmd/struct-to-graphql] using it to generate graphql schema for console * [cmd/struct-to-graphql] successfully generates graphql types, inputs, enums, handles nested structs, as well as inlining structs * apps/console mongo repo updated to give out paginated records * cursor based pagination finally coming through, able to paginate records based on user specified sort key, and page size * paginated query refactorings ... * struct-to-graphql types, input types, enums, common-types are being generated, but still need a stable sorting of generated fields, so that diff among multiple generations is kept at small * [cmd/struct-to-graphql] better parsing from struct and json-schema * cmd/struct-to-gql nested structs now have pkgpath prefixed to their name * [cmd/struct-to-graphql] graphql schema generation and dumping with unique nested structs generation, i.e. no repeating of types * [cmd/struct-to-graphql] tests are passing, reaching stability * [cmd/struct-to-graphql] tests are passing, json-schema tests are also passing * [cmd/struct-to-graphql] using it to generate graphql schema for console * [cmd/struct-to-graphql] successfully generates graphql types, inputs, enums, handles nested structs, as well as inlining structs * apps/console mongo repo updated to give out paginated records * cursor based pagination finally coming through, able to paginate records based on user specified sort key, and page size * paginated query refactorings ... * implemented pagination for workspaces, routers, apps, projects, configs, secrets, managed services and managed resources * resolves bugs in apps/nodectrl, and findPaginated method in mongo repo * removes old files, and comments cleanup * woker node with spot instance of aws support added in nodectrl (#28) * updated graphql schema from updated types, and throws error when creation fails for resources * [apps/infra] api pagination * infra pagination, and graphql type synchronisation across apollo federation --------- Co-authored-by: Abdhesh Nayak <abdheshnayak@gmail.com>
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
* added webhooks app, and ci updated to act as a consumer for git-webhooks messages pushed by webhooks, and process it and then send it to kloudlite-agent * just, some build config changes Former-commit-id: ab339a62b3051a6f0e9fa6af5a80614eb3381e0f
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* 🚧 wip * 🚧 wip * ✨ new improved nodectrl written nodectrl with support of digital ocean and aws with feature of creation and deletion added.
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* message office refactorings (#18) * [apps/console] msvc templates listing through graphql (#19) * Bugfix/optional oauth in auth api (#20) * [cmd/struct-to-graphql] basic grapqhl schema generation now available, with parsing from go struct as well as any json schema if provided through json-schema tag * [cmd/struct-to-graphql] kind of complete, can successfully generate graphql fields from specified json schema, and inline is also honored * [cmd/struct-to-graphql] adding tests for validating generated schema, now we should be able to refacator it with confidence * WIP: trying to come up with GraphQL schema generation from struct itself * implements provisions for OAuth implementation to be optional for each of the providers * changes container registry for image building and pushing (#21) * Feature/nodejob (#22) * 🚧 wip * 🚧 wip * ✨ new improved nodectrl written nodectrl with support of digital ocean and aws with feature of creation and deletion added. * Feature/nodejob (#23) Node Creation, Cluster Creation, Master node, and worker node management with the cloud provider AWS are done. * 🚧 wip (#24) Left changes form last pull request * [apps/nodectrl] taskfile updated to build nodectrl image locally (#26) * cursor based pagination for console api along with findpaginated for repo * struct-to-graphql types, input types, enums, common-types are being generated, but still need a stable sorting of generated fields, so that diff among multiple generations is kept at small * [cmd/struct-to-graphql] better parsing from struct and json-schema * cmd/struct-to-gql nested structs now have pkgpath prefixed to their name * [cmd/struct-to-graphql] graphql schema generation and dumping with unique nested structs generation, i.e. no repeating of types * [cmd/struct-to-graphql] tests are passing, reaching stability * [cmd/struct-to-graphql] tests are passing, json-schema tests are also passing * [cmd/struct-to-graphql] using it to generate graphql schema for console * [cmd/struct-to-graphql] successfully generates graphql types, inputs, enums, handles nested structs, as well as inlining structs * apps/console mongo repo updated to give out paginated records * cursor based pagination finally coming through, able to paginate records based on user specified sort key, and page size * paginated query refactorings ... * struct-to-graphql types, input types, enums, common-types are being generated, but still need a stable sorting of generated fields, so that diff among multiple generations is kept at small * [cmd/struct-to-graphql] better parsing from struct and json-schema * cmd/struct-to-gql nested structs now have pkgpath prefixed to their name * [cmd/struct-to-graphql] graphql schema generation and dumping with unique nested structs generation, i.e. no repeating of types * [cmd/struct-to-graphql] tests are passing, reaching stability * [cmd/struct-to-graphql] tests are passing, json-schema tests are also passing * [cmd/struct-to-graphql] using it to generate graphql schema for console * [cmd/struct-to-graphql] successfully generates graphql types, inputs, enums, handles nested structs, as well as inlining structs * apps/console mongo repo updated to give out paginated records * cursor based pagination finally coming through, able to paginate records based on user specified sort key, and page size * paginated query refactorings ... * implemented pagination for workspaces, routers, apps, projects, configs, secrets, managed services and managed resources * resolves bugs in apps/nodectrl, and findPaginated method in mongo repo * removes old files, and comments cleanup * woker node with spot instance of aws support added in nodectrl (#28) * updated graphql schema from updated types, and throws error when creation fails for resources * [apps/infra] api pagination * infra pagination, and graphql type synchronisation across apollo federation --------- Co-authored-by: Abdhesh Nayak <abdheshnayak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to lots of changes in the operator side and the API codebase. we needed an improved node controller job that can be extended at any level and is easy to maintain for future developers. so I rewrote the node controller with dependency injection and encapsulation with interfaces so it can be maintained at any level.
Type of change
Rewrite of Node Controller Job
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Sample ENV file
All encrypted values are base64 of Yaml files and don't contain any credentials as it is a sample file.
Test Configuration:
Checklist: