Feat/restart apps and managed services#237
Conversation
- **apps/tenant-agent**, now also have an action `restart`, apart from `apply`, and `delete`.
- this update, adds support for restarting managed services
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces a new feature that allows restarting both apps and project managed services. It includes updates to the GraphQL schema to support new resolver functions for restarting applications, as well as the necessary backend logic to handle the restart actions. Additionally, the PR includes updates to the GitHub issue template and the kloudlite/operator module.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Files deleted: Sourcery does not currently approve diffs with deleted files.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Ensure that new functionality, such as the 'restartK8sResource' method, is well-documented within the codebase to aid future maintainability.
- Implement comprehensive testing for the new restart feature to ensure it behaves as expected under various scenarios and handles errors gracefully.
- Review the error handling across the new resolvers to ensure consistency and that informative messages are returned to the client.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| } | ||
|
|
||
| func (d *domain) deleteK8sResourceOfCluster(ctx K8sContext, clusterName string, obj client.Object) error { | ||
| func (d *domain) restartK8sResource(ctx K8sContext, projectName string, namespace string, labels map[string]string) error { |
There was a problem hiding this comment.
suggestion (llm): Consider adding a comment explaining the purpose of 'restartK8sResource' and how it should be used, as it is a new addition to the domain logic.
| return true, nil | ||
| } | ||
|
|
||
| // CoreRestartApp is the resolver for the core_restartApp field. |
There was a problem hiding this comment.
suggestion (llm): The resolver 'CoreRestartApp' should handle potential errors from 'RestartApp' method gracefully and return user-friendly error messages.
| return true, nil | ||
| } | ||
|
|
||
| func (d *domain) RestartApp(ctx ResourceContext, appName string) error { |
There was a problem hiding this comment.
suggestion (llm): The new 'RestartApp' function should be thoroughly tested to ensure it correctly restarts the application and handles any potential errors.
Pull Request Review - SummaryHey there! 👋 Here's a summary of the previous tasks and their results for the pull request review. Let's dive in! Changes
Suggestions
Bugs
Improvements
RatingOverall, the code rates 7 out of 10 based on criteria such as readability, performance, and security. That's it for the summary! If you have any questions or need further clarification, feel free to reach out. Happy reviewing! 😄🔍 |
…services Feat/restart apps and managed services
1 participant
PR Description
Chore: Update
kloudlite/operatorkloudlite/operatormodule has been updated to the latest release (v1.0.5). This update brings support for restarting managed services, enhancing the overall functionality of the application.GitHub Issue Template
Feature: Restart API
apps/tenant-agentnow includes an action calledrestartin addition toapplyanddelete.Fix: GraphQL Updates
apps/inframoduleFix: Helm Release Status
apps/inframodule to address missing status in Helm releases. This ensures that the status information is accurately represented.