Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

🐛 Fixed issue with logs, where container_name needed to parse#247

Merged
abdheshnayak merged 1 commit into
mainfrom
issue/logs
Feb 5, 2024
Merged

🐛 Fixed issue with logs, where container_name needed to parse#247
abdheshnayak merged 1 commit into
mainfrom
issue/logs

Conversation

@abdheshnayak
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces enhancements to the logging system within a WebSocket server. It includes a fix for a typo in a variable name, an update to the subscription ID format to potentially include a broader set of logs, and an extension to the message response structure to include the container name derived from the message subject.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the wildcard character added to the subscription ID does not result in unintended subscriptions, which could lead to performance degradation or incorrect data being sent to clients.
  • Validate that the new 'Container' field in the 'MessageResponse' struct is properly handled by all clients consuming the WebSocket service to prevent any integration issues.
  • Implement additional checks to prevent potential index out of range errors when extracting the container name from the message subject, as this relies on the subject containing a specific format.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant