This repository was archived by the owner on Jun 11, 2025. It is now read-only.
🐛 Fixed issue with logs, where container_name needed to parse#247
Merged
Conversation
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces enhancements to the logging system within a WebSocket server. It includes a fix for a typo in a variable name, an update to the subscription ID format to potentially include a broader set of logs, and an extension to the message response structure to include the container name derived from the message subject.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the wildcard character added to the subscription ID does not result in unintended subscriptions, which could lead to performance degradation or incorrect data being sent to clients.
- Validate that the new 'Container' field in the 'MessageResponse' struct is properly handled by all clients consuming the WebSocket service to prevent any integration issues.
- Implement additional checks to prevent potential index out of range errors when extracting the container name from the message subject, as this relies on the subject containing a specific format.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.