Fix/iam account member role bindings, and resource metrics#250
Conversation
- There are no RoleBindings with `account-member` role, so, in case of resources eligible for users with `account-member` role, it used to end up in UnAuthorized. This commit fixes it.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces several enhancements and fixes across the IAM and observability functionalities. It addresses issues related to account member role bindings and resource metrics, improving the system's ability to handle user permissions and metrics retrieval more effectively. The changes include updates to error handling, the introduction of new GraphQL queries, and modifications to the way metrics are queried and displayed. Additionally, it refines the validation logic for role bindings and enhances the parsing of resource references.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that all new functionalities introduced are accompanied by adequate unit tests to maintain code quality and prevent regressions.
- Consider reviewing the performance implications of the changes, especially those involving loops and data structure manipulations, to ensure that they do not introduce performance bottlenecks.
- Review the debug logging statements to ensure that they do not inadvertently expose sensitive information.
- It might be beneficial to document the rationale behind significant changes or new functionalities for future reference and clarity.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Fix/iam account member role bindings, and resource metrics
1 participant
Description
closes #248
closes #249