feature(infra): added delete pv api

[nxtcoder19]

No description provided.

[sourcery-ai]

PR Type: Enhancement

PR Summary: This pull request introduces a new API for deleting persistent volumes (PVs) within the infrastructure management system. It includes backend changes to support this functionality, such as updates to GraphQL schema, resolver implementations, and domain logic. Additionally, it refactors the way target namespaces are generated during environment cloning and adjusts the display name for cloned resources.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.

• Sourcery currently only approves 'Typo fix' PRs.

✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.

No details provided.

📝 Complexity: the changes are too large or complex for Sourcery to approve.

• Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

• Ensure that the permission check for deleting a PV is appropriate and specific to PV deletion. The current implementation uses a permission check for deleting node pools, which might not be correct.
• Review the changes made to the environment cloning functionality, specifically the generation of target namespaces and the setting of display names for cloned resources, to ensure they align with the intended behavior and do not introduce regressions.
• Consider adding more context to the PR description to help reviewers understand the motivation behind these changes and how they fit into the larger system.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.