fix(apps/console): updates mres '.spec.resourceName' when cloning#253
Conversation
managed resources gh-issue: #252
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces enhancements to the environment cloning process within the console application. Specifically, it updates the cloning logic to ensure that cloned managed resources have unique .spec.resourceName values for different environments. Additionally, it includes changes to add IAM membership for the user in the context of the newly cloned environment and ensures the creation of necessary Kubernetes resources, such as namespaces, for the cloned environment. The modifications are aimed at improving the robustness and isolation of cloned environments.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure comprehensive testing around the new logic to prevent any potential regression, especially in the areas of IAM membership addition and Kubernetes resource creation.
- Consider adding more detailed logging around the IAM membership addition and Kubernetes resource application steps. This could be valuable for troubleshooting and auditing purposes.
- Review the error handling strategy to ensure that any issues encountered during the cloning process, especially with IAM and Kubernetes operations, are handled gracefully and communicated effectively to the caller.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
fix(apps/console): updates mres '.spec.resourceName' when cloning
closes #252
environment cloning now clones managed resource with different
.spec.releaseNamefor different environments