Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(apps/console): updates mres '.spec.resourceName' when cloning#253

Merged
nxtcoder17 merged 1 commit into
release-v1.0.1from
fix/env-cloning-mres
Feb 6, 2024
Merged

fix(apps/console): updates mres '.spec.resourceName' when cloning#253
nxtcoder17 merged 1 commit into
release-v1.0.1from
fix/env-cloning-mres

Conversation

@nxtcoder17
Copy link
Copy Markdown
Member

closes #252

environment cloning now clones managed resource with different .spec.releaseName for different environments

@nxtcoder17 nxtcoder17 self-assigned this Feb 6, 2024
@nxtcoder17 nxtcoder17 merged commit 9fa1926 into release-v1.0.1 Feb 6, 2024
@nxtcoder17 nxtcoder17 deleted the fix/env-cloning-mres branch February 6, 2024 18:13
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces enhancements to the environment cloning process within the console application. Specifically, it updates the cloning logic to ensure that cloned managed resources have unique .spec.resourceName values for different environments. Additionally, it includes changes to add IAM membership for the user in the context of the newly cloned environment and ensures the creation of necessary Kubernetes resources, such as namespaces, for the cloned environment. The modifications are aimed at improving the robustness and isolation of cloned environments.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure comprehensive testing around the new logic to prevent any potential regression, especially in the areas of IAM membership addition and Kubernetes resource creation.
  • Consider adding more detailed logging around the IAM membership addition and Kubernetes resource application steps. This could be valuable for troubleshooting and auditing purposes.
  • Review the error handling strategy to ensure that any issues encountered during the cloning process, especially with IAM and Kubernetes operations, are handled gracefully and communicated effectively to the caller.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
fix(apps/console): updates mres '.spec.resourceName' when cloning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 After cloning Environment, managed resources are never getting ready

1 participant