Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(console): implement project deletion even when cluster is deleted#259

Merged
nxtcoder17 merged 2 commits into
release-v1.0.2from
fix/project-deletion
Feb 8, 2024
Merged

fix(console): implement project deletion even when cluster is deleted#259
nxtcoder17 merged 2 commits into
release-v1.0.2from
fix/project-deletion

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

@nxtcoder19 nxtcoder19 commented Feb 8, 2024

fix(console): implement project deletion even when cluster is deleted
fix(infra): added grpc api for cluster existance

Resolves kloudlite/kloudlite#22

fix(console): implement project deletion even when cluster is deleted
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces a new gRPC API for checking the existence of a cluster within the infrastructure services. It also implements logic in the console domain to handle project deletion even when the associated cluster is already deleted. This enhancement addresses the issue of ensuring projects can be deleted without dependency on the cluster's existence, improving the robustness of project management.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
  • Big diff: the diff is too large to approve with confidence.

General suggestions:

  • Ensure comprehensive testing around the new ClusterExists API, particularly focusing on edge cases such as network failures or unauthorized access.
  • Consider adding more detailed logging within the new functionality to aid in debugging and operational monitoring.
  • Review the direct use of string literals for method names in gRPC client method invocations across the services for consistency and accuracy.
  • Verify that the removal of constants for method names and the transition to inline string literals does not impact any dynamic method name resolution or references throughout the codebase.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Removal of explicit full method names as constants simplifies the code and relies on inline string literals for method names. Ensure that this change does not impact any dynamic usage of these constants elsewhere in the codebase.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Similar to the finance service, the removal of explicit full method names as constants in the IAM service also streamlines the code. Verify that no dynamic references to these constants are broken by this change.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The removal of constants for full method names in the Comms service follows the pattern seen in other services. Ensure consistency across all services and check for any potential impact on dynamic method name resolution.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Removing explicit constants for full method names and using inline string literals directly in method invocations simplifies the code. Ensure consistency and correctness of method names across the service.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The removal of constants for method names in the Auth service aligns with the changes in other services. Verify that this does not affect any dynamic references to these constants.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The deletion of method name constants in the Finance service and direct use of string literals is noted. Ensure that all method names are accurately reflected and consistent with the server-side implementation.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Removing constants for method names in the CI service and using inline strings may streamline the code. Double-check for any potential impact on dynamic method name resolution or references.

// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

const (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The Container Registry service's shift away from using constants for method names to inline strings is consistent with other services. Confirm that this change does not disrupt any dynamic usage of these method names.

@nxtcoder17 nxtcoder17 force-pushed the fix/project-deletion branch from 18e4d2b to 682738f Compare February 8, 2024 14:48
@nxtcoder17 nxtcoder17 merged commit e1521ee into release-v1.0.2 Feb 8, 2024
@nxtcoder17 nxtcoder17 deleted the fix/project-deletion branch February 8, 2024 14:50
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
fix(console): implement project deletion even when cluster is deleted
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KLO-91] Project & its resources should be deleted immediately if there is no cluster attached.

2 participants