Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(infra): Add clustername in nats event publishing#264

Merged
nxtcoder17 merged 1 commit into
release-v1.0.2from
fix/infra-nats-event
Feb 12, 2024
Merged

fix(infra): Add clustername in nats event publishing#264
nxtcoder17 merged 1 commit into
release-v1.0.2from
fix/infra-nats-event

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

@nxtcoder19 nxtcoder19 commented Feb 12, 2024

Add clustername in nats event publishing for below resources:

  • helm release
  • domain entry (via Ingress resource)

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces the addition of the cluster name in NATS event publishing for helm releases and domain entries. It modifies the event publishing method calls to include the cluster name as a parameter, ensuring that the events are more contextually rich and identifiable by their respective cluster. This change is applied across various operations such as creation, update, and deletion of both helm releases and domain entries.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure consistency in event types across all operations. There was an oversight where a delete operation for a Helm release incorrectly used PublishUpdate instead of PublishDelete. It's crucial to maintain accuracy in event types to avoid confusion and potential bugs in event handling.
  • Review the changes to ensure that all event publishing now correctly includes the cluster name. This enhancement improves the granularity and usability of the event data, which is beneficial for subscribers that may need to take cluster-specific actions.
  • Consider the broader impact of these changes on the system, especially in terms of how subscribers handle these events. The addition of the cluster name might require updates to event subscribers to properly process the new event format.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 merged commit 2cf1fd5 into release-v1.0.2 Feb 12, 2024
@nxtcoder17 nxtcoder17 deleted the fix/infra-nats-event branch February 12, 2024 05:29
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
fix(infra): adds clustername in nats event publishing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants