fix(infra): Add clustername in nats event publishing#264
Conversation
…ces: - helm release - domain entry
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces the addition of the cluster name in NATS event publishing for helm releases and domain entries. It modifies the event publishing method calls to include the cluster name as a parameter, ensuring that the events are more contextually rich and identifiable by their respective cluster. This change is applied across various operations such as creation, update, and deletion of both helm releases and domain entries.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure consistency in event types across all operations. There was an oversight where a delete operation for a Helm release incorrectly used
PublishUpdateinstead ofPublishDelete. It's crucial to maintain accuracy in event types to avoid confusion and potential bugs in event handling. - Review the changes to ensure that all event publishing now correctly includes the cluster name. This enhancement improves the granularity and usability of the event data, which is beneficial for subscribers that may need to take cluster-specific actions.
- Consider the broader impact of these changes on the system, especially in terms of how subscribers handle these events. The addition of the cluster name might require updates to event subscribers to properly process the new event format.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
fix(infra): adds clustername in nats event publishing
Add clustername in nats event publishing for below resources: