Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(console/infra): fixes returnning nil instead of err typo#266

Merged
nxtcoder17 merged 1 commit into
release-v1.0.2from
fix/error-update-schemaresolver
Feb 12, 2024
Merged

fix(console/infra): fixes returnning nil instead of err typo#266
nxtcoder17 merged 1 commit into
release-v1.0.2from
fix/error-update-schemaresolver

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

change error return type in schema resolver

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Bug fix

PR Summary: This pull request addresses the issue of inconsistent error handling in schema resolvers across the console and infrastructure components. It standardizes the error return type by wrapping errors with a custom error wrapper, errors.NewE, in various mutation resolvers. This change ensures that errors are consistently handled and propagated, improving the system's reliability and debuggability.

Decision: Comment

📝 Type: 'Bug fix' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Consider adding a brief explanation in the PR description about the impact of these changes on the existing system, especially how it improves error handling.
  • It might be beneficial to include a small section in the PR description or comments about how this change was tested or the testing strategy to ensure that error handling behaves as expected after these changes.
  • Review the consistency of error handling across other parts of the application to ensure that this approach is uniformly applied where applicable.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 changed the title fix(console/infra): change error return type in schema resolver fix(console/infra): fixes returnning nil instead of err typo Feb 12, 2024
@nxtcoder19 nxtcoder19 force-pushed the fix/error-update-schemaresolver branch from baaf900 to d6c861e Compare February 12, 2024 16:40
@nxtcoder17 nxtcoder17 merged commit 5ff4287 into release-v1.0.2 Feb 12, 2024
@nxtcoder17 nxtcoder17 deleted the fix/error-update-schemaresolver branch February 12, 2024 16:43
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
fix(console/infra): fixes returnning nil instead of err typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants