This repository was archived by the owner on Jun 11, 2025. It is now read-only.
fix(console/infra): fixes returnning nil instead of err typo#266
Merged
Conversation
There was a problem hiding this comment.
PR Type: Bug fix
PR Summary: This pull request addresses the issue of inconsistent error handling in schema resolvers across the console and infrastructure components. It standardizes the error return type by wrapping errors with a custom error wrapper, errors.NewE, in various mutation resolvers. This change ensures that errors are consistently handled and propagated, improving the system's reliability and debuggability.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Consider adding a brief explanation in the PR description about the impact of these changes on the existing system, especially how it improves error handling.
- It might be beneficial to include a small section in the PR description or comments about how this change was tested or the testing strategy to ensure that error handling behaves as expected after these changes.
- Review the consistency of error handling across other parts of the application to ensure that this approach is uniformly applied where applicable.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
baaf900 to
d6c861e
Compare
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
fix(console/infra): fixes returnning nil instead of err typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change error return type in schema resolver