feat: adds graphql API to upgrade kloudite agent helm on tenant cluster#271
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces functionality to upgrade the Kloudlite agent helm on tenant clusters via a new GraphQL API. It adds new message types for getting cluster tokens and implements the upgrade logic within the domain layer. Additionally, it exposes this functionality through a new GraphQL mutation, allowing clients to trigger the upgrade process.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Ensure the upgrade process is idempotent to avoid unintended changes or errors when the same version is applied.
- Implement thorough error handling and input validation in the
GetClusterTokenmethod to maintain service integrity. - Document the expected behavior and limitations of the
InfraUpgradeHelmKloudliteAgentmutation to guide API consumers.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| return nil | ||
| } | ||
|
|
||
| func (d *domain) UpgradeHelmKloudliteAgent(ctx InfraContext, clusterName string) error { |
There was a problem hiding this comment.
suggestion (llm): The introduction of UpgradeHelmKloudliteAgent is a significant addition. It's crucial to ensure that the upgrade process is idempotent. Given the nature of Helm upgrades, if the same version is applied, it should not result in changes or errors. This is important for maintaining stability in automated environments.
| } | ||
|
|
||
| func newInternalMsgServer(d domain.Domain) *internalMsgServer { | ||
| func (s *internalMsgServer) GetClusterToken(ctx context.Context, in *message_office_internal.GetClusterTokenIn) (*message_office_internal.GetClusterTokenOut, error) { |
There was a problem hiding this comment.
suggestion (llm): Implementing the GetClusterToken method is crucial for the functionality of the MessageOfficeInternal service. It's important to ensure proper error handling and validation of input parameters to maintain the integrity of the service.
…ent-on-target feat: adds graphql API to upgrade kloudite agent helm on tenant cluster
1 participant
No description provided.