This repository was archived by the owner on Jun 11, 2025. It is now read-only.
[KLO-139] fix(apps/console): fixes applying configmap and secret to target#273
Merged
Conversation
There was a problem hiding this comment.
PR Type: Bug fix
PR Summary: This pull request addresses issues related to the application of configuration maps and secrets within the console application. It includes changes to the handling of annotations for configurations and secrets, ensuring they are properly initialized and populated. Additionally, it corrects the behavior of resource deletion to use the appropriate repository, addressing a potential bug in the deletion of environments.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Consider adding more context in the PR description about the impact of these changes on the existing functionality and any potential side effects.
- Review the initialization of maps for annotations to ensure that the chosen approach aligns with the expected usage patterns and performance considerations.
- Ensure comprehensive testing around the changed areas, particularly focusing on the edge cases that might arise from the modifications to the handling of annotations and resource deletion.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
fix(apps/console): fixes applying configmap and secret to target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.