Feat/accounts kloudlite cr creds#279
Conversation
READ-ONLY token, and store in that account's namespace
kloudlite registry credentials. - fixes handling of `docker push` /events
to new environments when created - [pkg/k8s] adds utility to list secrets by a given type - [taskfiles/go-build] improves go build task, now passing `upx=false`, will disable upx compression
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces functionality to ensure Kloudlite registry credentials are available for accounts. It modifies the GraphQL schema to include a new query for ensuring Kloudlite registry pull secrets, updates domain logic to handle the creation and retrieval of these secrets, and integrates with the container registry service via gRPC to create read-only credentials. Additionally, it includes changes to manage the lifecycle of these secrets within Kubernetes namespaces associated with accounts and environments.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Consider adding more detailed logging around the creation and retrieval of registry credentials to aid in debugging and monitoring.
- Ensure that error handling is robust, especially in the interaction with external services like Kubernetes and the container registry, to gracefully handle failures.
- Review the security implications of storing and accessing registry credentials, ensuring that they are securely handled and that access is appropriately restricted.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Feat/accounts kloudlite cr creds
1 participant
No description provided.