Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

[KLO-159] feat(container-registry): now also lists forks in search repos API#280

Merged
nxtcoder17 merged 1 commit into
mainfrom
fix/gitub-forks-listing-container-registry
Feb 28, 2024
Merged

[KLO-159] feat(container-registry): now also lists forks in search repos API#280
nxtcoder17 merged 1 commit into
mainfrom
fix/gitub-forks-listing-container-registry

Conversation

@nxtcoder17
Copy link
Copy Markdown
Member

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces enhancements to the container registry's search repositories API by now also listing forks in the search results. It involves modifications to the internal GitHub integration logic, including the addition of a logging mechanism and adjustments to the search query to include forks. The changes aim to resolve an issue identified in the project's issue tracker, enhancing the functionality of the API to provide more comprehensive search results.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Consider verifying the impact of including forks in the search results on the overall performance and relevance of the search functionality. Including forks could potentially increase the volume of results, so it might be beneficial to assess if any filtering or ranking adjustments are needed to maintain the usefulness of the search results.
  • It's good practice to monitor the usage and performance of the updated API feature post-deployment. Gathering feedback from users and analyzing usage patterns can provide valuable insights for future enhancements or adjustments.
  • The addition of a logging mechanism is a positive step towards improving observability within the application. It would be beneficial to ensure that logging levels are appropriately set to capture relevant information without overwhelming the log storage with too much data.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 changed the title feat(container-registry): now also lists forks in search repos API [KLO-159] feat(container-registry): now also lists forks in search repos API Feb 28, 2024
@nxtcoder17 nxtcoder17 merged commit 55bb0cf into main Feb 28, 2024
@nxtcoder17 nxtcoder17 deleted the fix/gitub-forks-listing-container-registry branch February 28, 2024 08:19
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
…ner-registry

feat(container-registry): now also lists forks in search repos API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KLO-159] not able to find forked repos in github when searching for image build

1 participant