Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(infra): remove statefull type from nodepool entity #285

Merged
nxtcoder17 merged 1 commit into from
Mar 4, 2024
Merged

fix(infra): remove statefull type from nodepool entity #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 4 additions & 90 deletions apps/infra/internal/app/graph/generated/generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions apps/infra/internal/app/graph/model/models_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion apps/infra/internal/app/graph/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ input SearchClusterManagedService {

input SearchNodepool {
text: MatchFilterIn
isStateful: MatchFilterIn
}

input SearchHelmRelease {
Expand Down
2 changes: 0 additions & 2 deletions apps/infra/internal/app/graph/struct-to-graphql/nodepool.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ type NodePool @shareable {
metadata: Metadata @goField(name: "objectMeta")
recordVersion: Int!
spec: Github__com___kloudlite___operator___apis___clusters___v1__NodePoolSpec!
stateful: Boolean!
status: Github__com___kloudlite___operator___pkg___operator__Status
syncStatus: Github__com___kloudlite___api___pkg___types__SyncStatus!
updateTime: Date!
Expand All @@ -35,6 +34,5 @@ input NodePoolIn {
kind: String
metadata: MetadataIn
spec: Github__com___kloudlite___operator___apis___clusters___v1__NodePoolSpecIn!
stateful: Boolean!
}

9 changes: 0 additions & 9 deletions apps/infra/internal/domain/nodepool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,6 @@ func (d *domain) UpdateNodePool(ctx InfraContext, clusterName string, nodePoolIn
return nil, errors.NewE(err)
}

np, err := d.findNodePool(ctx, clusterName, nodePoolIn.Name)
if err != nil {
return nil, errors.NewE(err)
}

if np.IsStateful != nodePoolIn.IsStateful {
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Given the removal of the IsStateful property from the NodePool entity, it's crucial to ensure that any logic previously dependent on this property is appropriately adjusted or removed. This includes any tests that might have been checking the behavior or state changes based on the IsStateful property. Please verify if there are existing tests covering this logic and update or remove them as necessary to reflect the current state of the codebase.

return nil, errors.Newf("You can't change stateful value, aborting update")
}

patchForUpdate := common.PatchForUpdate(
ctx,
&nodePoolIn,
Expand Down
1 change: 0 additions & 1 deletion apps/infra/internal/entities/nodepool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ type NodePool struct {
ClusterName string `json:"clusterName" graphql:"noinput"`

SyncStatus t.SyncStatus `json:"syncStatus" graphql:"noinput"`
IsStateful bool `json:"stateful"`
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): With the IsStateful property being removed from the NodePool entity, it's essential to review any entity-level tests that might have been asserting on this property's presence or value. If such tests exist, they should be updated to align with the current entity structure, ensuring that our test suite accurately reflects the codebase's state.

}

func (n *NodePool) GetDisplayName() string {
Expand Down