🎨 Updated gql and k8s-schema in infra and console#292
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey abdheshnayak - Here's my review!
General suggestions:
- Ensure that the refactoring does not introduce any regressions by thoroughly testing all affected resolvers.
- Review the simplification of type declarations for clarity and maintainability.
- Consider the broader impact of these changes on the system, especially in areas interacting with the updated schemas.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| metadataResolver struct{ *Resolver } | ||
| metadataInResolver struct{ *Resolver } | ||
| ) | ||
| type github__com___kloudlite___api___common__CreatedOrUpdatedByResolver struct{ *Resolver } |
There was a problem hiding this comment.
suggestion (llm): Given the changes in types, it's crucial to ensure that the existing unit tests for these resolvers are updated to reflect the new type structures. If there are no existing tests, this is a good opportunity to add them to verify that the resolvers behave as expected with the updated types.
| secretResolver struct{ *Resolver } | ||
| secretInResolver struct{ *Resolver } | ||
| ) | ||
| type secretResolver struct{ *Resolver } |
There was a problem hiding this comment.
suggestion (llm): The refactoring of the secretResolver and secretInResolver types suggests a change in the underlying implementation. Please ensure that there are comprehensive tests covering these resolvers, particularly focusing on edge cases and error handling. If such tests are missing, consider adding them.
| mutationResolver struct{ *Resolver } | ||
| queryResolver struct{ *Resolver } | ||
| ) | ||
| type mutationResolver struct{ *Resolver } |
There was a problem hiding this comment.
suggestion (llm): The simplification of type declarations for mutationResolver and queryResolver indicates a structural change. It's important to verify through tests that these changes do not affect the functionality, especially for complex queries and mutations. Ensure that both positive and negative test cases are covered.
| metadataResolver struct{ *Resolver } | ||
| metadataInResolver struct{ *Resolver } | ||
| ) | ||
| type github__com___kloudlite___api___common__CreatedOrUpdatedByResolver struct{ *Resolver } |
There was a problem hiding this comment.
issue (llm): This pull request does not include modifications to test files. Given the nature of the changes, it's essential to ensure that the tests are aligned with the new type structures to prevent potential regressions. Please add or update tests accordingly.
🎨 Updated gql and k8s-schema in infra and console
1 participant
Updated k8s-schema and gql, because of types changes on operator.