This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Update gatway subgraph using rover#295
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder19 - I've reviewed your changes and they look great!
General suggestions:
- Consider using asynchronous file operations in the gateway application to enhance performance and avoid blocking the event loop.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| }; | ||
|
|
||
| const cfgMap = yaml.load(await fs.readFile(useEnv("SUPERGRAPH_CONFIG"), 'utf8')); | ||
|
|
There was a problem hiding this comment.
suggestion (performance): Consider using asynchronous file reading with fs.promises.readFile instead of fs.readFileSync to avoid blocking the event loop, especially since this operation is performed at the startup.
Suggested change
| -const superGraphSchema = fs.readFileSync("./prod-schema.graphql"); | |
| +const superGraphSchema = await fs.promises.readFile("./prod-schema.graphql", "utf-8"); |
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
Update gatway subgraph using rover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.