fix: gateway supergraph build script updates

[nxtcoder17]

No description provided.

[sourcery-ai]

Hey @nxtcoder17 - I've reviewed your changes and they look great!

General suggestions:

• Consider validating the 'out' variable in the generate-schema.sh script to ensure it handles paths with spaces or special characters gracefully.
• Review the changes to ensure that the dynamic output path for the schema generation does not introduce any unexpected behavior in different environments.
• Ensure that the removal of the Generate Schema step in the GitHub workflow does not impact other dependent processes or workflows.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

[sourcery-ai]

suggestion (code_refinement): It's good practice to quote shell variables to prevent globbing and word splitting. However, ensure that the variable out is always expected to be a single word or path without spaces, or this could lead to unexpected behavior.

Suggested change

	rover supergraph compose --config ./supergraph.yml --output "$out" --elv2-license accept
	if [[ "$out" =~ \ |\' ]]; then
	echo "Error: The output path ('out') contains spaces or single quotes, which might cause unexpected behavior."
	exit 1
	fi
	rover supergraph compose --config ./supergraph.yml --output "$out" --elv2-license accept