This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Improve/websock and cr#299
Merged
Merged
Conversation
There was a problem hiding this comment.
Hey @abdheshnayak - I've reviewed your changes and found some issues that need to be addressed.
General suggestions:
- Ensure that all new methods and changes adhere to existing security protocols, especially regarding the handling of secrets and tokens.
- Review the logging level changes to ensure they align with the intended severity and information disclosure policies.
- Consider the impact of the new admin credential creation method on existing workflows and ensure it integrates smoothly with the current system architecture.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| if err != nil { | ||
| return nil, errors.NewE(err) | ||
| } | ||
| token, err := admin.GenerateToken(KL_ADMIN, credential.AccountName, string(credential.Access), i, d.envs.RegistrySecretKey+credential.AccountName) |
There was a problem hiding this comment.
🚨 issue (security): Hard-coded secret detected in the concatenation of d.envs.RegistrySecretKey with credential.AccountName. This approach can potentially expose sensitive information. Consider securely managing secrets, for example, through a secrets manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.