Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Improve/websock and cr #300

Merged
abdheshnayak merged 6 commits into from
Mar 14, 2024
Merged

Improve/websock and cr #300

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f1be41
:recycle: Updated registry cred generation for grpc of cr
abdheshnayak Mar 14, 2024
a5cce23
:art: Added recordversion to websocker logs message
abdheshnayak Mar 14, 2024
61b35a4
:bug: Handled logs for also without recordversion
abdheshnayak Mar 14, 2024
e244fd4
Merge branch 'main' of github.com:kloudlite/api
abdheshnayak Mar 14, 2024
d58d6cb
:bug: Handled logs for also without recordversion
abdheshnayak Mar 14, 2024
1eaf85b
Merge branch 'improve/websock-and-cr' of github.com:kloudlite/api int…
abdheshnayak Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/websocket-server/internal/domain/logs/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type MsgData struct {
Cluster string `json:"cluster"`
TrackingId string `json:"trackingId"`
Since *string `json:"since,omitempty"`
RecordVersion int `json:"recordVersion"`
RecordVersion *int `json:"recordVersion"`
}

type Message struct {
Expand Down Expand Up @@ -101,5 +101,10 @@ func ParseSince(since *string) (*time.Time, error) {
}

func LogSubsId(md MsgData, logStreamName string) string {

if md.RecordVersion == nil {
return fmt.Sprintf("%s.%s.%s.%s.>", logStreamName, md.Account, md.Cluster, md.TrackingId)
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (typo): The format string ends with a >. If this is intentional, ensure that it aligns with the expected format for all consumers of this ID. If not, it might be a typo that could lead to inconsistencies in ID formatting.

}
Comment on lines +105 to +107
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_clarification): Consider adding a comment explaining why a nil RecordVersion leads to a different format in LogSubsId. This could help maintainers understand the business logic or technical reasons behind this decision.


return fmt.Sprintf("%s.%s.%s.%s.%d.>", logStreamName, md.Account, md.Cluster, md.TrackingId, md.RecordVersion)
}