Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

🐛 Fixed issue with record version#303

Merged
abdheshnayak merged 1 commit into
mainfrom
fix/issue-with-record-version
Mar 18, 2024
Merged

🐛 Fixed issue with record version#303
abdheshnayak merged 1 commit into
mainfrom
fix/issue-with-record-version

Conversation

@abdheshnayak
Copy link
Copy Markdown
Contributor

@abdheshnayak abdheshnayak commented Mar 18, 2024

  • fixed issue with the record version in websocket server.
  • removed record version parsing in registry as not needed for now.

in websocket record version handled wrongly. in registry no need of record version.
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abdheshnayak - I've reviewed your changes and they look great!

General suggestions:

  • Ensure that the removal of record version parsing and matching does not impact the functionality where record version checks are critical.
  • Consider adding inline comments explaining the rationale behind setting the record version to 0 in PatchById calls, for future maintainability.
  • Review the broader impact of these changes on the system, especially in areas where record versioning might be critical for data consistency.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@abdheshnayak abdheshnayak merged commit 8dca19c into main Mar 18, 2024
@abdheshnayak abdheshnayak deleted the fix/issue-with-record-version branch March 18, 2024 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant