This repository was archived by the owner on Jun 11, 2025. It is now read-only.
✨ feature/multi cluster (#309)#309
Merged
Merged
Conversation
Contributor
abdheshnayak
commented
Apr 9, 2024
abdheshnayak
commented
- added resource watch for cluster-connection types.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @abdheshnayak - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -0,0 +1,87 @@ | |||
| package entities | |||
There was a problem hiding this comment.
suggestion (code_refinement): Validate the uniqueness and constraints of ClusterGroup indices.
Ensure that the defined indices for ClusterGroup, especially those marked as unique, are validated against the existing data model to prevent potential conflicts.
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* ✨ Implemented cluster-connection watch and update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.