Impl/code verification#324
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder36 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| CreationTime func(childComplexity int) int | ||
| DisplayName func(childComplexity int) int | ||
| ID func(childComplexity int) int | ||
| Id func(childComplexity int) int |
There was a problem hiding this comment.
suggestion: Inconsistent naming convention for 'Id'.
The change from 'ID' to 'Id' is inconsistent with Go naming conventions, which typically use 'ID' for acronyms. Consider reverting to 'ID' for consistency and readability.
| Id func(childComplexity int) int | |
| ID func(childComplexity int) int |
|
|
||
| case "Account.id": | ||
| if e.complexity.Account.ID == nil { | ||
| if e.complexity.Account.Id == nil { |
There was a problem hiding this comment.
suggestion: Inconsistent naming convention for 'Id'.
The change from 'ID' to 'Id' is inconsistent with Go naming conventions, which typically use 'ID' for acronyms. Consider reverting to 'ID' for consistency and readability.
| if e.complexity.Account.Id == nil { | |
| if e.complexity.Account.ID == nil { |
|
|
||
| case "Invitation.id": | ||
| if e.complexity.Invitation.ID == nil { | ||
| if e.complexity.Invitation.Id == nil { |
There was a problem hiding this comment.
suggestion: Inconsistent naming convention for 'Id'.
The change from 'ID' to 'Id' is inconsistent with Go naming conventions, which typically use 'ID' for acronyms. Consider reverting to 'ID' for consistency and readability.
| if e.complexity.Invitation.Id == nil { | |
| if e.complexity.Invitation.ID == nil { |
| resTmp, err := ec.ResolverMiddleware(ctx, func(rctx context.Context) (interface{}, error) { | ||
| ctx = rctx // use context from middleware stack in children | ||
| return ec.resolvers.Account().ID(rctx, obj) | ||
| return obj.Id, nil |
There was a problem hiding this comment.
suggestion: Inconsistent naming convention for 'Id'.
The change from 'ID' to 'Id' is inconsistent with Go naming conventions, which typically use 'ID' for acronyms. Consider reverting to 'ID' for consistency and readability.
| return obj.Id, nil | |
| return obj.ID, nil |
2 participants
Waitinglist on signup implementation