This repository was archived by the owner on Jun 11, 2025. It is now read-only.
feat(infra): global vpn support with loadbalancer#328
Merged
Conversation
- fixes BYOK cluster deletion - patches Cluster Endpoint for both kloudlite clusters (with NodePorts), and BYOK clusters (with LoadBalancer)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder17 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| - name: init | ||
| image: busybox:1.32.0 | ||
| command: | ||
| - sh |
There was a problem hiding this comment.
issue (performance): Commented out resource limits and requests
Commenting out resource limits and requests can lead to resource contention or unbounded resource usage. Ensure this is intentional and that the deployment environment can handle potential resource spikes.
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
feat(infra): global vpn support with loadbalancer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves kloudlite/kloudlite#223