API: Implement import managed resource by nxtcoder19 · Pull Request #329 · kloudlite/api

nxtcoder19 · 2024-05-30T09:51:53Z

Resolves kloudlite/kloudlite#224

sourcery-ai

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 14 issues found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

sourcery-ai · 2024-05-30T09:55:20Z

 	ManagedResource struct {
 		APIVersion            func(childComplexity int) int
 		AccountName           func(childComplexity int) int
+		ClusterName           func(childComplexity int) int


suggestion: Consider adding a comment for the new field.

Adding a comment for the new ClusterName field would improve code readability and maintainability.

Suggested change

ClusterName func(childComplexity int) int

// ClusterName represents the name of the cluster associated with the managed resource.

ClusterName func(childComplexity int) int

sourcery-ai · 2024-05-30T09:55:20Z

 		Enabled               func(childComplexity int) int
 		EnvironmentName       func(childComplexity int) int
 		Id                    func(childComplexity int) int
+		IsImported            func(childComplexity int) int


suggestion: Consider adding a comment for the new field.

Adding a comment for the new IsImported field would improve code readability and maintainability.

Suggested change

IsImported func(childComplexity int) int

// IsImported indicates whether the item is imported.

IsImported func(childComplexity int) int

sourcery-ai · 2024-05-30T09:55:20Z

+		IsImported            func(childComplexity int) int
 		Kind                  func(childComplexity int) int
 		LastUpdatedBy         func(childComplexity int) int
+		ManagedServiceName    func(childComplexity int) int


suggestion: Consider adding a comment for the new field.

Adding a comment for the new ManagedServiceName field would improve code readability and maintainability.

Suggested change

ManagedServiceName func(childComplexity int) int

// ManagedServiceName represents the complexity function for the ManagedServiceName field.

ManagedServiceName func(childComplexity int) int

sourcery-ai · 2024-05-30T09:55:20Z

 		LastUpdatedBy         func(childComplexity int) int
+		ManagedServiceName    func(childComplexity int) int
 		MarkedForDeletion     func(childComplexity int) int
+		MresRef               func(childComplexity int) int


suggestion: Consider adding a comment for the new field.

Adding a comment for the new MresRef field would improve code readability and maintainability.

Suggested change

MresRef func(childComplexity int) int

// MresRef is a function that calculates the complexity of the MresRef field.

MresRef func(childComplexity int) int

sourcery-ai · 2024-05-30T09:55:20Z

-		CoreGetManagedResouceOutputKeyValues func(childComplexity int, envName string, keyrefs []*domain.ManagedResourceKeyRef) int
-		CoreGetManagedResouceOutputKeys      func(childComplexity int, envName string, name string) int
-		CoreGetManagedResource               func(childComplexity int, envName string, name string) int
+		CoreGetImportedManagedResource       func(childComplexity int, envName string, name string) int


suggestion: Consider adding a comment for the new function.

Adding a comment for the new CoreGetImportedManagedResource function would improve code readability and maintainability.

Suggested change

CoreGetImportedManagedResource func(childComplexity int, envName string, name string) int

// CoreGetImportedManagedResource calculates the complexity for fetching an imported managed resource.

// It takes into account the child complexity, environment name, and resource name.

CoreGetImportedManagedResource func(childComplexity int, envName string, name string) int

sourcery-ai · 2024-05-30T09:55:21Z

+	return d.mresRepo.FindPaginated(ctx, d.mresRepo.MergeMatchFilters(filters, search), pq)
+}

+func (d *domain) ListImportedManagedResources(ctx ResourceContext, search map[string]repos.MatchFilter, pq repos.CursorPagination) (*repos.PaginatedRecord[*entities.ManagedResource], error) {


suggestion: Consider adding a comment for the new function.

Adding a comment for the new ListImportedManagedResources function would improve code readability and maintainability.

Suggested change

func (d *domain) ListImportedManagedResources(ctx ResourceContext, search map[string]repos.MatchFilter, pq repos.CursorPagination) (*repos.PaginatedRecord[*entities.ManagedResource], error) {

func (d *domain) ListImportedManagedResources(ctx ResourceContext, search map[string]repos.MatchFilter, pq repos.CursorPagination) (*repos.PaginatedRecord[*entities.ManagedResource], error) {

// ListImportedManagedResources retrieves a paginated list of managed resources

// based on the provided search filters and pagination parameters.

// It ensures the user has read permissions in the specified environment.

sourcery-ai · 2024-05-30T09:55:21Z

 }

-func (d *domain) findMRes(ctx ResourceContext, name string) (*entities.ManagedResource, error) {
+func (d *domain) listImportedMres(ctx ConsoleContext, mresName string) ([]*entities.ManagedResource, error) {


suggestion: Consider adding a comment for the new function.

Adding a comment for the new listImportedMres function would improve code readability and maintainability.

Suggested change

func (d *domain) listImportedMres(ctx ConsoleContext, mresName string) ([]*entities.ManagedResource, error) {

func (d *domain) listImportedMres(ctx ConsoleContext, mresName string) ([]*entities.ManagedResource, error) {

// listImportedMres retrieves a list of imported Managed Resources based on the provided name.

// It returns a slice of pointers to ManagedResource entities and an error if any occurs during the process.

sourcery-ai · 2024-05-30T09:55:21Z

+func (d *domain) listImportedMres(ctx ConsoleContext, mresName string) ([]*entities.ManagedResource, error) {
+
+	filter := repos.Filter{
+		fields.AccountName:        ctx.AccountName,


suggestion: Consider adding a comment for the new field.

Adding a comment for the new AccountName field would improve code readability and maintainability.

Suggested change

fields.AccountName: ctx.AccountName,

// AccountName is used to filter resources by the account associated with the context

fields.AccountName: ctx.AccountName,

sourcery-ai · 2024-05-30T09:55:21Z

+
+	filter := repos.Filter{
+		fields.AccountName:        ctx.AccountName,
+		fc.ManagedResourceMresRef: mresName,


suggestion: Consider adding a comment for the new field.

Adding a comment for the new ManagedResourceMresRef field would improve code readability and maintainability.

Suggested change

fc.ManagedResourceMresRef: mresName,

// ManagedResourceMresRef is used to filter resources based on the managed resource reference name.

fc.ManagedResourceMresRef: mresName,

sourcery-ai · 2024-05-30T09:55:21Z

 	return nil
 }

+type GetClusterManagedServiceIn struct {


suggestion: Consider adding validation for new struct fields

Adding validation for fields like UserId, UserName, UserEmail, AccountName, and MsvcName can help ensure data integrity and prevent potential issues.

Suggested change

type GetClusterManagedServiceIn struct {

type GetClusterManagedServiceIn struct {

state protoimpl.MessageState

sizeCache protoimpl.SizeCache

UserId string `validate:"required"`

UserName string `validate:"required"`

UserEmail string `validate:"required,email"`

AccountName string `validate:"required"`

MsvcName string `validate:"required"`

}

- refactor managed resource to create inside managed service - implement import managed resource inside environment

API: Implement import managed resource

Add import mres implementation

ab85c38

nxtcoder19 requested review from karthik1729 and nxtcoder17 as code owners May 30, 2024 09:51

sourcery-ai Bot reviewed May 30, 2024

View reviewed changes

nxtcoder19 force-pushed the feat/import-mres branch from 1a225b0 to faacc55 Compare May 31, 2024 02:37

fix(console/managed resource):

a593f7a

- refactor managed resource to create inside managed service - implement import managed resource inside environment

nxtcoder19 force-pushed the feat/import-mres branch from faacc55 to a593f7a Compare May 31, 2024 05:05

nxtcoder17 approved these changes May 31, 2024

View reviewed changes

nxtcoder17 merged commit 5100de1 into main May 31, 2024

nxtcoder17 deleted the feat/import-mres branch May 31, 2024 05:14

abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024

Merge pull request #329 from kloudlite/feat/import-mres

f0a0e1c

API: Implement import managed resource

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API: Implement import managed resource #329

API: Implement import managed resource #329
nxtcoder17 merged 2 commits into
mainfrom
feat/import-mres

nxtcoder19 commented May 30, 2024

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

sourcery-ai Bot May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	ClusterName func(childComplexity int) int
	// ClusterName represents the name of the cluster associated with the managed resource.
	ClusterName func(childComplexity int) int

	IsImported func(childComplexity int) int
	// IsImported indicates whether the item is imported.
	IsImported func(childComplexity int) int

	ManagedServiceName func(childComplexity int) int
	// ManagedServiceName represents the complexity function for the ManagedServiceName field.
	ManagedServiceName func(childComplexity int) int

	MresRef func(childComplexity int) int
	// MresRef is a function that calculates the complexity of the MresRef field.
	MresRef func(childComplexity int) int

-func (d *domain) ListImportedManagedResources(ctx ResourceContext, search map[string]repos.MatchFilter, pq repos.CursorPagination) (*repos.PaginatedRecord[*entities.ManagedResource], error) {
+func (d *domain) ListImportedManagedResources(ctx ResourceContext, search map[string]repos.MatchFilter, pq repos.CursorPagination) (*repos.PaginatedRecord[*entities.ManagedResource], error) {
+    // ListImportedManagedResources retrieves a paginated list of managed resources
+    // based on the provided search filters and pagination parameters.
+    // It ensures the user has read permissions in the specified environment.

	fields.AccountName: ctx.AccountName,
	// AccountName is used to filter resources by the account associated with the context
	fields.AccountName: ctx.AccountName,

	fc.ManagedResourceMresRef: mresName,
	// ManagedResourceMresRef is used to filter resources based on the managed resource reference name.
	fc.ManagedResourceMresRef: mresName,

-type GetClusterManagedServiceIn struct {
+type GetClusterManagedServiceIn struct {
+	state         protoimpl.MessageState
+	sizeCache     protoimpl.SizeCache
+	UserId        string `validate:"required"`
+	UserName      string `validate:"required"`
+	UserEmail     string `validate:"required,email"`
+	AccountName   string `validate:"required"`
+	MsvcName      string `validate:"required"`
+}

Conversation

nxtcoder19 commented May 30, 2024

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants