This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feature/notification n alert#330
Merged
Merged
Conversation
Reviewer's Guide by SourceryThis pull request adds support for basic notifications and alerts push functionality. The changes include the implementation of notification processing, email template parsing, and integration with various notification channels such as email, Slack, Telegram, and webhooks. Additionally, it introduces GraphQL resolvers for managing notification configurations and subscriptions. File-Level Changes
|
There was a problem hiding this comment.
Hey @abdheshnayak - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* ✨ Initial Implementation of Notifications and Alers * ✨ Added notification support in comms * 🎨 Implemented resolvers * 🎨 Consts updated * ✨ Added gql to comms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request introduces basic notifications and alerts support, including email, Slack, Telegram, and webhook notifications. It adds GraphQL schema and resolvers for managing notifications and subscriptions, implements notification processing and delivery mechanisms, and refactors email template handling. Additionally, it updates the comms service to use a unified email template structure and enhances the domain layer to include notification and subscription management.