Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

🎨 Fixed minor issue in comms for notification and alert#331

Merged
abdheshnayak merged 1 commit into
mainfrom
improvement/notifications-n-alerts
Jun 6, 2024
Merged

🎨 Fixed minor issue in comms for notification and alert#331
abdheshnayak merged 1 commit into
mainfrom
improvement/notifications-n-alerts

Conversation

@abdheshnayak
Copy link
Copy Markdown
Contributor

@abdheshnayak abdheshnayak commented Jun 6, 2024

  • fixed minor issues in comms for notification and alerts.

Summary by Sourcery

This pull request introduces a new mutation to mark all notifications as read in the comms service. It also updates the comms service to include a new HTTP server lifecycle hook and changes the routing URL for the comms-api in the supergraph configuration.

  • New Features:
    • Added a new mutation to mark all notifications as read in the comms service.
  • Enhancements:
    • Updated the comms service to include a new HTTP server lifecycle hook for starting and stopping the server.
  • Deployment:
    • Changed the routing URL for the comms-api in the supergraph configuration.

@abdheshnayak abdheshnayak merged commit 02878f6 into main Jun 6, 2024
@abdheshnayak abdheshnayak deleted the improvement/notifications-n-alerts branch June 6, 2024 12:25
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 6, 2024

Reviewer's Guide by Sourcery

This pull request addresses minor issues in the communications module related to notifications and alerts. The primary change is the addition of a new functionality to mark all notifications as read. This involves updates to the GraphQL schema, resolver functions, and domain logic. Additionally, there are some configuration changes to the server setup and environment variables.

File-Level Changes

Files Changes
apps/comms/internal/app/graph/generated/generated.go
apps/comms/internal/app/graph/schema.resolvers.go
Updated GraphQL schema and resolvers to support marking all notifications as read.
apps/comms/internal/domain/notification.go
apps/comms/internal/domain/api.go
Implemented domain logic to mark all notifications as read and updated the Domain interface.
apps/comms/internal/framework/framework.go
apps/comms/internal/env/env.go
Added server lifecycle management and updated environment configuration to include HTTP port.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abdheshnayak - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

abdheshnayak added a commit that referenced this pull request Nov 5, 2024
…erts

🎨 Fixed minor issue in comms for notification and alert
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant