Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Refactor/imported mres#332

Merged
nxtcoder17 merged 4 commits into
mainfrom
refactor/imported-mres
Jun 9, 2024
Merged

Refactor/imported mres#332
nxtcoder17 merged 4 commits into
mainfrom
refactor/imported-mres

Conversation

@nxtcoder17
Copy link
Copy Markdown
Member

@nxtcoder17 nxtcoder17 commented Jun 9, 2024

Summary by Sourcery

This pull request refactors the managed resource context to support both managedServiceName and environmentName, introduces new features for specifying clusterName in environment cloning, and adds structured BYOK cluster setup instructions. It also removes deprecated queries and improves error handling and validation.

  • New Features:
    • Introduced support for specifying clusterName in the CoreCloneEnvironment mutation.
    • Added envName as an optional filter for managed resource queries.
    • Introduced BYOKSetupInstruction type and related GraphQL schema changes for better structuring of BYOK cluster setup instructions.
  • Enhancements:
    • Refactored managed resource context to support both managedServiceName and environmentName.
    • Updated CoreGetManagedResouceOutputKeyValues and CoreGetManagedResouceOutputKeys to accept optional envName and msvcName parameters.
    • Improved error handling and validation for managed resource operations.
  • Chores:
    • Removed deprecated CoreListImportedManagedResources and CoreGetImportedManagedResource queries.
    • Updated Taskfile.yml in tenant-agent to fix the output path for the build command.

@nxtcoder17 nxtcoder17 requested a review from karthik1729 as a code owner June 9, 2024 23:01
@nxtcoder17 nxtcoder17 self-assigned this Jun 9, 2024
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 9, 2024

Reviewer's Guide by Sourcery

This pull request refactors the codebase to improve the handling of managed resources and environment cloning. It introduces new fields and modifies existing ones to enhance functionality and flexibility. The changes include updates to GraphQL schema, resolver functions, and domain logic.

File-Level Changes

Files Changes
apps/console/internal/app/graph/generated/generated.go
apps/infra/internal/app/graph/generated/generated.go
Updated GraphQL schema and resolver functions to include new parameters and types.
apps/console/internal/domain/mres.go
apps/console/internal/app/graph/schema.resolvers.go
apps/console/internal/domain/api.go
apps/console/internal/domain/environment.go
Refactored managed resource and environment cloning logic to use new context structure and parameters.
apps/infra/internal/app/graph/schema.resolvers.go
apps/infra/internal/domain/byok-clusters.go
apps/infra/internal/app/graph/model/models_gen.go
Updated BYOK cluster setup instructions to return structured data instead of plain strings.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder17 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 force-pushed the refactor/imported-mres branch from 6cf7e8e to 68f5e11 Compare June 9, 2024 23:03
@nxtcoder17 nxtcoder17 merged commit 2ea5463 into main Jun 9, 2024
@nxtcoder17 nxtcoder17 deleted the refactor/imported-mres branch June 9, 2024 23:37
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant