This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Refactor/imported mres#332
Merged
Merged
Conversation
Reviewer's Guide by SourceryThis pull request refactors the codebase to improve the handling of managed resources and environment cloning. It introduces new fields and modifies existing ones to enhance functionality and flexibility. The changes include updates to GraphQL schema, resolver functions, and domain logic. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @nxtcoder17 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
6cf7e8e to
68f5e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request refactors the managed resource context to support both
managedServiceNameandenvironmentName, introduces new features for specifyingclusterNamein environment cloning, and adds structured BYOK cluster setup instructions. It also removes deprecated queries and improves error handling and validation.clusterNamein theCoreCloneEnvironmentmutation.envNameas an optional filter for managed resource queries.BYOKSetupInstructiontype and related GraphQL schema changes for better structuring of BYOK cluster setup instructions.managedServiceNameandenvironmentName.CoreGetManagedResouceOutputKeyValuesandCoreGetManagedResouceOutputKeysto accept optionalenvNameandmsvcNameparameters.CoreListImportedManagedResourcesandCoreGetImportedManagedResourcequeries.tenant-agentto fix the output path for the build command.