This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feat/private byok cluster#335
Merged
Merged
Conversation
- each public gvpn gateway has:
+ all other public gvpn gateways as its peers
+ as well as, kloudlite gvpn gateway as its peer, (it acts like a
central hub in communication to/from all other devices, and
private gateways)
- each private gvpn gateway has:
+ only kloudlite gvpn gateway as its peer, and cluster CIDRs of all
other public/private clusters in AllowedIPs
Reviewer's Guide by SourceryThis pull request introduces a new feature to support private BYOK (Bring Your Own Key) clusters. The changes primarily involve modifications to the global VPN connection logic to handle private and public clusters differently. Additionally, new fields and constants related to cluster visibility are added to various files. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder17 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| AuthSecretKeys *GithubComKloudliteAPIAppsInfraInternalEntitiesAWSAuthSecretKeysIn `json:"authSecretKeys,omitempty"` | ||
| } | ||
|
|
||
| type GithubComKloudliteAPIAppsInfraInternalEntitiesClusterVisbility struct { |
There was a problem hiding this comment.
issue (typo): Fix typo in struct name.
The struct name 'GithubComKloudliteAPIAppsInfraInternalEntitiesClusterVisbility' contains a typo. It should be 'GithubComKloudliteAPIAppsInfraInternalEntitiesClusterVisibility'.
- upgrades github.com/kloudlite/operator to latest commit
nxtcoder17
force-pushed
the
feat/private-byok-cluster
branch
from
31fb0d7 to
494031a
Compare
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
Feat/private byok cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves kloudlite/kloudlite#219
Resolves kloudlite/kloudlite#246
Resolves kloudlite/kloudlite#247
Summary by Sourcery
This pull request introduces support for filtering Global VPN connections by public and private clusters. It refactors the
getGlobalVPNConnectionPeersfunction to accept a struct with filtering options, updates theensureGlobalVPNConnectionfunction to remove theclusterPublicEndpointparameter, and adds new constants for cluster visibility. Additionally, new GraphQL types and resolvers for cluster visibility have been implemented.getGlobalVPNConnectionPeersfunction to accept a struct with filtering options.ensureGlobalVPNConnectionfunction to remove theclusterPublicEndpointparameter.