Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix: migrating environment cache from kv, back to db#337

Merged
nxtcoder17 merged 1 commit into
mainfrom
fix/env-cluster-cache-burst
Jun 13, 2024
Merged

fix: migrating environment cache from kv, back to db#337
nxtcoder17 merged 1 commit into
mainfrom
fix/env-cluster-cache-burst

Conversation

@nxtcoder17
Copy link
Copy Markdown
Member

@nxtcoder17 nxtcoder17 commented Jun 13, 2024

@nxtcoder17 nxtcoder17 self-assigned this Jun 13, 2024
@nxtcoder17 nxtcoder17 requested a review from karthik1729 as a code owner June 13, 2024 15:40
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 13, 2024

Reviewer's Guide by Sourcery

This pull request migrates the environment cache from a key-value store back to a database. The changes involve removing the caching logic from the getClusterAttachedToEnvironment function and simplifying the code to directly query the database. Additionally, an unused constant is removed from the generated_constants.go file.

File-Level Changes

Files Changes
apps/console/internal/domain/environment.go
apps/infra/internal/entities/field-constants/generated_constants.go
Migrated environment cache from key-value store back to database and removed unused constants.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder17 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 merged commit 718de30 into main Jun 13, 2024
@nxtcoder17 nxtcoder17 deleted the fix/env-cluster-cache-burst branch June 13, 2024 15:43
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
fix: migrating environment cache from kv, back to db
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Environment creation issue

1 participant