This repository was archived by the owner on Jun 11, 2025. It is now read-only.
API: implement clone managed service#338
Merged
Merged
Conversation
Reviewer's Guide by SourceryThis pull request implements the 'clone managed service' feature for the API. The changes include adding a new mutation to the GraphQL schema, implementing the corresponding resolver, and updating the domain logic to handle the cloning of a managed service. The changes also include updates to role bindings and action types to support the new functionality. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder19 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| return fmt.Sprintf("cmsvc-%s", msvcName) | ||
| } | ||
|
|
||
| func (d *domain) CloneClusterManagedService(ctx InfraContext, args CloneManagedServiceArgs) (*entities.ClusterManagedService, error) { |
There was a problem hiding this comment.
suggestion: Consider adding validation for CloneManagedServiceArgs.
Before proceeding with the cloning operation, it would be prudent to validate the CloneManagedServiceArgs to ensure all required fields are present and correctly formatted.
nxtcoder17
approved these changes
Jun 14, 2024
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
API: implements clone managed service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves kloudlite/kloudlite#249
Summary by Sourcery
This pull request introduces a new feature to clone a managed service within a cluster. It adds a new GraphQL mutation
infra_cloneClusterManagedServiceand implements the corresponding domain logic. Additionally, role bindings are updated to include permissions for this new action.infra_cloneClusterManagedServiceto clone a managed service within a cluster.CloneClusterManagedServicein the domain layer to handle the cloning logic for cluster managed services.CloneClusterManagedServiceaction.