This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feat/cluster online offline#339
Merged
Merged
Conversation
Office - whenever `kloudlite-agent` from a tenant-cluster, connects to Message Office, the cluster is marked as online, and current timestamp is stored as `LastOnlineTime`
- auto disconnection after `MaxConnectionDuration` (default: 45 seconds), helps with message office load-balancing, and frequent checks for cluster online/offline status
Reviewer's Guide by SourceryThis pull request implements the feature to mark clusters as online or offline. It introduces new gRPC message types and methods for marking clusters online, updates the domain logic to handle the new functionality, and integrates the changes into the message-office service. Additionally, it updates the protoc version across multiple gRPC interface files. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @nxtcoder17 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
Feat/cluster online offline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves kloudlite/kloudlite#235
Summary by Sourcery
This pull request introduces new gRPC methods and message types for marking clusters as online, adds a
LastOnlineAtfield to track the last online timestamp for clusters, and implements corresponding GraphQL resolvers. It also includes various enhancements such as updating theprotocversion, improving connection handling intenant-agent, and refactoring server initialization inmessage-office.MarkClusterOnlineAtInandMarkClusterOnlineAtOut.LastOnlineAtfield toClusterandBYOKClusterentities to track the last online timestamp.LastOnlineAtfield inClusterandBYOKCluster.grpc-interfacesto useprotocversionv4.24.4.grpcServerinmessage-officeto includeinfraClientfor marking clusters as online.NewMessageOfficeServerto acceptinfraConnfor initializinginfraClient.grpcHandlerintenant-agentto handle connection timeouts and retries more gracefully.envTargetNamespacemethod ofconsoledomain.Taskfile.ymlto includegrpc-interfacestaskfile.