Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

generate managed service schema#344

Merged
nxtcoder19 merged 2 commits into
mainfrom
impl/archive-msvc
Jun 28, 2024
Merged

generate managed service schema#344
nxtcoder19 merged 2 commits into
mainfrom
impl/archive-msvc

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

@nxtcoder19 nxtcoder19 commented Jun 28, 2024

Summary by Sourcery

This pull request introduces a new 'isArchived' field to the ClusterManagedService schema, enhancing the ability to manage and query the archival status of services.

  • New Features:
    • Added 'isArchived' field to the ClusterManagedService schema, allowing the system to track whether a service is archived.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 28, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new field, isArchived, to the ClusterManagedService GraphQL schema. The changes include updates to the complexity calculation, input type, resolver function, and field context handling to support the new field.

File-Level Changes

Files Changes
apps/infra/internal/app/graph/generated/generated.go Introduced the isArchived field to the ClusterManagedService GraphQL schema, including its complexity, input type, resolver, and field context handling.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@nxtcoder19 nxtcoder19 requested a review from abdheshnayak June 28, 2024 06:29
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder19 nxtcoder19 merged commit c03b15f into main Jun 28, 2024
@nxtcoder19 nxtcoder19 deleted the impl/archive-msvc branch July 1, 2024 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants