Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Update sent mail option while signup and verify#347

Merged
nxtcoder17 merged 1 commit into
release-v1.0.7from
update/auth
Jul 10, 2024
Merged

Update sent mail option while signup and verify#347
nxtcoder17 merged 1 commit into
release-v1.0.7from
update/auth

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

@nxtcoder19 nxtcoder19 commented Jul 10, 2024

Summary by Sourcery

This pull request updates the email communication during the signup and verification processes. Specifically, it changes the signup process to send a verification token email and the verification process to send a welcome email upon successful verification.

  • Enhancements:
    • Updated the signup process to send a verification token email instead of a waiting email.
    • Modified the email verification process to send a welcome email upon successful verification.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 10, 2024

Reviewer's Guide by Sourcery

This pull request refactors the email sending logic in the user signup and email verification processes. Specifically, it removes the call to SendWaitingEmail during signup and replaces it with a call to generateAndSendVerificationToken. Additionally, it updates the VerifyEmail function to send a welcome email instead of a waiting email.

File-Level Changes

Files Changes
apps/auth/internal/domain/impl.go Refactored email sending logic during user signup and email verification processes.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder19 nxtcoder19 changed the base branch from main to release-v1.0.7 July 10, 2024 11:11
@nxtcoder17 nxtcoder17 merged commit 28d45b5 into release-v1.0.7 Jul 10, 2024
@nxtcoder17 nxtcoder17 deleted the update/auth branch July 10, 2024 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants