Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Check mres name availability based on managedservice name#348

Merged
nxtcoder17 merged 2 commits into
release-v1.0.7from
check/mres-name
Jul 11, 2024
Merged

Check mres name availability based on managedservice name#348
nxtcoder17 merged 2 commits into
release-v1.0.7from
check/mres-name

Conversation

@nxtcoder19
Copy link
Copy Markdown
Contributor

@nxtcoder19 nxtcoder19 commented Jul 10, 2024

Summary by Sourcery

Enhanced the CoreCheckNameAvailability functionality by adding support for an optional msvcName parameter, allowing for more specific name availability checks based on managed service names.

  • Enhancements:
    • Extended the CoreCheckNameAvailability function to include an optional msvcName parameter for more granular name availability checks.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 10, 2024

Reviewer's Guide by Sourcery

This pull request updates the CoreCheckNameAvailability functionality to include a new 'msvcName' parameter. Changes were made to the GraphQL schema, resolver functions, and domain logic to support this new parameter. Error handling and filter logic were also updated to ensure 'msvcName' is properly validated and utilized.

File-Level Changes

Files Changes
apps/console/internal/app/graph/generated/generated.go
apps/console/internal/app/graph/schema.resolvers.go
Updated GraphQL schema and resolver functions to include 'msvcName' parameter in CoreCheckNameAvailability query.
apps/console/internal/domain/names.go
apps/console/internal/domain/api.go
Added 'msvcName' parameter to CheckNameAvailability function and updated error handling and filter logic.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nxtcoder17 nxtcoder17 merged commit 3889d50 into release-v1.0.7 Jul 11, 2024
@nxtcoder17 nxtcoder17 deleted the check/mres-name branch July 11, 2024 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants