This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Check mres name availability based on managedservice name#348
Merged
Conversation
Reviewer's Guide by SourceryThis pull request updates the CoreCheckNameAvailability functionality to include a new 'msvcName' parameter. Changes were made to the GraphQL schema, resolver functions, and domain logic to support this new parameter. Error handling and filter logic were also updated to ensure 'msvcName' is properly validated and utilized. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @nxtcoder19 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
5eb903e to
beb9b89
Compare
nxtcoder17
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhanced the CoreCheckNameAvailability functionality by adding support for an optional msvcName parameter, allowing for more specific name availability checks based on managed service names.