Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix: updates apps on cluster, when removing all device intercepts#360

Merged
nxtcoder17 merged 1 commit into
release-v1.0.7from
fix/remove-device-intercepts-dispatch
Aug 22, 2024
Merged

fix: updates apps on cluster, when removing all device intercepts#360
nxtcoder17 merged 1 commit into
release-v1.0.7from
fix/remove-device-intercepts-dispatch

Conversation

@nxtcoder17
Copy link
Copy Markdown
Member

@nxtcoder17 nxtcoder17 commented Aug 22, 2024

Resolves kloudlite/kloudlite#276

Summary by Sourcery

Fix the issue where apps on the cluster were not updated when all device intercepts were removed by applying the updated app configuration after patching.

Bug Fixes:

  • Ensure apps on the cluster are updated when all device intercepts are removed by applying the updated app configuration after patching.

@nxtcoder17 nxtcoder17 self-assigned this Aug 22, 2024
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 22, 2024

Reviewer's Guide by Sourcery

This pull request addresses an issue related to updating apps on a cluster when removing all device intercepts. The changes are implemented in the apps/console/internal/domain/app.go file, focusing on the RemoveDeviceIntercepts and OnAppUpdateMessage functions. The main modifications involve applying app updates and improving error handling.

File-Level Changes

Files Changes
apps/console/internal/domain/app.go Added app update application after patching in RemoveDeviceIntercepts function
apps/console/internal/domain/app.go Improved error handling in RemoveDeviceIntercepts function
apps/console/internal/domain/app.go Refactored OnAppUpdateMessage function for better readability

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@nxtcoder17 nxtcoder17 merged commit 670f417 into release-v1.0.7 Aug 22, 2024
@nxtcoder17 nxtcoder17 deleted the fix/remove-device-intercepts-dispatch branch August 22, 2024 03:28
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder17 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] console remove device intercepts, is not sending updated apps to the cluster

1 participant