fix: acknowledges cluster's visibility with GlobalVPN Gateway

[nxtcoder17]

Summary by Sourcery

Fix the handling of cluster visibility in GlobalVPN connections and refactor the ensureGlobalVPNConnection function to use a structured argument for improved code clarity.

Bug Fixes:

• Acknowledge cluster visibility in the GlobalVPN connection process to ensure correct handling of cluster visibility settings.

Enhancements:

• Refactor the ensureGlobalVPNConnection function to use a structured argument for better clarity and maintainability.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the GlobalVPN connection handling in the infrastructure domain to accommodate cluster visibility. It introduces a new struct for arguments and updates function signatures and calls to include visibility information.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Refactored ensureGlobalVPNConnection function to use a new struct for arguments	Created a new struct 'ensureGlobalVPNConnectionArgs' to encapsulate function parameters Updated function signature to use the new struct Modified function calls to use the new struct Added 'Visibility' field to the argument struct and function logic	apps/infra/internal/domain/global-vpn-cluster-connection.go apps/infra/internal/domain/byok-clusters.go apps/infra/internal/domain/clusters.go
Updated GlobalVPNConnection creation to include visibility information	Added 'Visibility' field to the GlobalVPNConnection struct Modified createGlobalVPNConnection call to include visibility information	apps/infra/internal/domain/global-vpn-cluster-connection.go
Minor code style changes in GraphQL resolver file	Grouped type declarations for globalVPNResolver and globalVPNInResolver	apps/infra/internal/app/graph/globalvpn.resolvers.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nxtcoder17 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding documentation for the new ensureGlobalVPNConnectionArgs struct to explain its purpose and the significance of each field.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}