Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Conversation

@nader-ziada
Copy link
Contributor

Changes

  • The certificate reconciler should use the local reconciler instead of the one from the pkg repo
  • This local reconciler uses the filtered informer that the pkg one doesn't support

/kind bug

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Nov 7, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #231 (e627333) into main (b8842c8) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   73.11%   72.89%   -0.22%     
==========================================
  Files          23       23              
  Lines        1380     1380              
==========================================
- Hits         1009     1006       -3     
- Misses        315      317       +2     
- Partials       56       57       +1     
Impacted Files Coverage Δ
pkg/certificates/reconciler/certificates.go 69.52% <ø> (ø)
pkg/network/base_connection.go 89.28% <0.00%> (-2.68%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@knative-prow knative-prow bot merged commit b12acb3 into knative-extensions:main Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants