Skip to content

Pin k8s version for minikube #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 2 commits into from
Oct 19, 2021
Merged

Pin k8s version for minikube #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88915bd
pin k8s version for minikube
psschwei Oct 15, 2021
d749acb
updating to k8s v1.22
psschwei Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kind/kind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"knative.dev/kn-plugin-quickstart/pkg/install"
)

var kubernetesVersion = "v1.21.1@sha256:fae9a58f17f18f06aeac9772ca8b5ac680ebbed985e266f711d936e91d113bad"
var kubernetesVersion = "v1.22.2@sha256:f638a08c1f68fe2a99e724ace6df233a546eaf6713019a0b310130a4f91ebe7f"
var clusterName = "knative"
var kindVersion = 0.11

Expand Down
3 changes: 2 additions & 1 deletion pkg/minikube/minikube.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
)

var clusterName = "minikube-knative"
var kubernetesVersion = "1.22.2"
var minikubeVersion = 1.23

// SetUp creates a local Minikube cluster and installs all the relevant Knative components
Expand Down Expand Up @@ -151,7 +152,7 @@ func createNewCluster() error {
fmt.Print(" minikube config set driver <your-driver>\n\n")

// create cluster and wait until ready
createCluster := exec.Command("minikube", "start", "--cpus", "3", "--profile", clusterName, "--wait", "all")
createCluster := exec.Command("minikube", "start", "--kubernetes-version", kubernetesVersion, "--cpus", "3", "--profile", clusterName, "--wait", "all")
if err := runCommandWithOutput(createCluster); err != nil {
return fmt.Errorf("minikube create: %w", err)
}
Expand Down