Skip to content

Add eventing-gitlab repo to update-nightlies workflow#402

Merged
knative-prow[bot] merged 6 commits into
knative-extensions:mainfrom
harsh098:eventing-gitlab-nightlies-update
Sep 9, 2024
Merged

Add eventing-gitlab repo to update-nightlies workflow#402
knative-prow[bot] merged 6 commits into
knative-extensions:mainfrom
harsh098:eventing-gitlab-nightlies-update

Conversation

@harsh098
Copy link
Copy Markdown
Contributor

@harsh098 harsh098 commented Aug 28, 2024

Changes

assignee: @harsh098
Add eventing-gitlab repo to update-nightlies workflow.

/kind

Fixes #

Release Note

Docs

@harsh098
Add eventing-gitlab repo to update-nightlies workflow
159ff57 
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Aug 28, 2024

@harsh098: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

assignee: @harsh098
Add eventing-gitlab repo to update-nightlies workflow.

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Aug 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow Bot requested review from cardil and upodroid August 28, 2024 19:51
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Aug 28, 2024

Welcome @harsh098! It looks like this is your first PR to knative-extensions/knobots 🎉

@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@harsh098 harsh098 mentioned this pull request Aug 28, 2024
Open
creydr
creydr suggested changes Aug 29, 2024
View reviewed changes
Comment thread .github/workflows/update-nightlies.yaml Outdated
Comment thread .github/workflows/update-nightlies.yaml Outdated
Comment thread .github/workflows/update-nightlies.yaml Outdated
Comment thread .github/workflows/update-nightlies.yaml Outdated
Comment thread .github/workflows/update-nightlies.yaml Outdated
@harsh098 @creydr
Remove Empty Lines in update-nightlies workflow
f3c3148 
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2024
harsh098 and others added 4 commits August 29, 2024 12:29
@harsh098 @creydr
Modify nightly name for eventing-gitlab repo in update-nighlies workflow
e354e73 
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@harsh098 @creydr
Modify bucket name for eventing-gitlab nightly
a3d489b 
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@harsh098 @creydr
Modify fork for eventing-gitlab in update-nightlies workflow
cb1b729 
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
@harsh098
Remove eventing-tls-networking.yaml from eventing-gitlab nightly in u…
551ce8f 
…pdate-nighlies workflow

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2024
@harsh098
Copy link
Copy Markdown
Contributor Author

harsh098 commented Aug 29, 2024

Requested Changes had been made @creydr
Pls review

@harsh098
Copy link
Copy Markdown
Contributor Author

harsh098 commented Sep 7, 2024

Any updates @creydr @cardil ?

creydr
creydr approved these changes Sep 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, harsh098

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@creydr
Copy link
Copy Markdown
Contributor

creydr commented Sep 9, 2024

Sorry for the delay @harsh098. Somehow missed this. Looks good so far

@knative-prow knative-prow Bot merged commit 36b11a6 into knative-extensions:main Sep 9, 2024
@nicknikolakakis nicknikolakakis mentioned this pull request May 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

1 more reviewer

@creydr creydr creydr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@creydr creydr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsh098 @creydr