Skip to content

add kn-plugin-event#61

Merged
knative-prow-robot merged 1 commit into
knative-extensions:mainfrom
rhuss:pr/kn-plugin-event
Mar 23, 2021
Merged

add kn-plugin-event#61
knative-prow-robot merged 1 commit into
knative-extensions:mainfrom
rhuss:pr/kn-plugin-event

Conversation

@rhuss
Copy link
Copy Markdown
Contributor

@rhuss rhuss commented Mar 15, 2021

No description provided.

@rhuss rhuss requested a review from a team as a code owner March 15, 2021 17:54
@rhuss rhuss requested review from a team March 15, 2021 17:54
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 15, 2021
Copy link
Copy Markdown
Contributor

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I seem to recall that some of the plugin directories don't have update-deps set up. Would you prefer PRs to create update-deps or to disable that particular path?

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2021
@knative-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c80937b into knative-extensions:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants