Skip to content

Remove configmap volume mounts#301

Merged
knative-prow-robot merged 1 commit intoknative-extensions:masterfrom
MIBc:volume
Jul 6, 2020
Merged

Remove configmap volume mounts#301
knative-prow-robot merged 1 commit intoknative-extensions:masterfrom
MIBc:volume

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jul 5, 2020

Fixes #120

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 5, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 5, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2020
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jul 6, 2020

/assign @mattmoor

mattmoor
mattmoor reviewed Jul 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@knative-prow-robot knative-prow-robot merged commit 9a536f3 into knative-extensions:master Jul 6, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop configmap volume mounts

4 participants

@MIBc @knative-prow-robot @mattmoor @googlebot