Skip to content

Add leader-election config#302

Merged
knative-prow-robot merged 1 commit intoknative-extensions:masterfrom
MIBc:leader
Jul 20, 2020
Merged

Add leader-election config#302
knative-prow-robot merged 1 commit intoknative-extensions:masterfrom
MIBc:leader

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jul 8, 2020

Fixes #233

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 8, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 8, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jul 8, 2020

/assign @mattmoor

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Jul 20, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2020
mattmoor
mattmoor reviewed Jul 20, 2020
View reviewed changes
Comment thread config/config-leader-election.yaml
Comment on lines +46 to +48
# enabledComponents is a comma-delimited list of component names for which
# leader election is enabled. Valid values are:
enabledComponents: "controller,webhook"
Copy link
Copy Markdown
Contributor

@mattmoor mattmoor Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed.

n3wscott
n3wscott reviewed Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@n3wscott n3wscott mentioned this pull request Jul 20, 2020
Closed
@knative-prow-robot knative-prow-robot merged commit 1b3cd3e into knative-extensions:master Jul 20, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaikas vaikas Awaiting requested review from vaikas

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the configs for leader election

5 participants

@MIBc @knative-prow-robot @n3wscott @mattmoor @googlebot