Skip to content

project POD_NAME into the deployments for logging purpose#246

Merged
knative-prow-robot merged 1 commit into
knative-extensions:masterfrom
tom24d:issue-166
Jan 18, 2021
Merged

project POD_NAME into the deployments for logging purpose#246
knative-prow-robot merged 1 commit into
knative-extensions:masterfrom
tom24d:issue-166

Conversation

@tom24d
Copy link
Copy Markdown
Contributor

@tom24d tom24d commented Jan 9, 2021

Fixes #166 .

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2021

Codecov Report

Merging #246 (ab2f09c) into master (584c5f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   68.57%   68.57%           
=======================================
  Files           6        6           
  Lines          70       70           
=======================================
  Hits           48       48           
  Misses         20       20           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584c5f0...6e46647. Read the comment docs.

@lberk
Copy link
Copy Markdown
Member

lberk commented Jan 18, 2021

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, tom24d

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2021
@knative-prow-robot knative-prow-robot merged commit 13da83a into knative-extensions:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass pod names as env var in deployments for logging purposes

3 participants