Skip to content

Address issue 535 for golangci-lint-action #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krsna-m wants to merge 1 commit into from
Closed

Address issue 535 for golangci-lint-action #124

krsna-m wants to merge 1 commit into from

Conversation

@krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Mar 27, 2023

Changes

There is an issue golangci/golangci-lint-action#535 that has golangci-lint-action lint unchanged files which we are now seeing. People report that setting the version v1.47.3 address this issue.

  • 🐛 Fix bug

@knative-prow knative-prow bot requested review from cardil and upodroid March 27, 2023 14:25
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@krsna-m
Copy link
Contributor Author

krsna-m commented Mar 27, 2023

/hold until tested

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2023
@dprotaso
Copy link
Member

dprotaso commented Mar 27, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso mentioned this pull request Mar 27, 2023
Merged
@krsna-m
Copy link
Contributor Author

krsna-m commented Mar 27, 2023

golangci/golangci-lint-action#440 is seen when downgrading.
Closing in favor of #125

@krsna-m krsna-m closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krsna-m @dprotaso